Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webviewFindWidget focus steal, fixes #127456 #128176

Closed
wants to merge 1 commit into from

Conversation

rzhao271
Copy link
Contributor

@rzhao271 rzhao271 commented Jul 8, 2021

This PR fixes #127456

A screencap demonstrating the fix

@rzhao271 rzhao271 added this to the July 2021 milestone Jul 8, 2021
@rzhao271 rzhao271 requested review from bpasero and mjbvz July 8, 2021 00:17
@rzhao271 rzhao271 self-assigned this Jul 8, 2021
@bpasero bpasero removed their request for review July 8, 2021 05:34
@bpasero
Copy link
Member

bpasero commented Jul 8, 2021

This is awesome 👍 , I let Matt review it though as that is his code area.

@rzhao271
Copy link
Contributor Author

rzhao271 commented Jul 8, 2021

Looks like Matt already fixed it. Closing

@rzhao271 rzhao271 closed this Jul 8, 2021
@mjbvz
Copy link
Collaborator

mjbvz commented Jul 8, 2021

Ah sorry about that @rzhao271! I didn't realize my fix for another issue was similar to what you added here

Please let me know if the fix I added doesn't work here for some reason

@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2021
@rzhao271 rzhao271 deleted the rzhao271/iframe-focus-steal branch December 15, 2022 19:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cut, copy, paste don't work in iframe find
3 participants